Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78825?usp=email )
Change subject: soc/intel/*: Correct ACPI device name for eMMC ......................................................................
soc/intel/*: Correct ACPI device name for eMMC
The ACPI name of any device needs to match the name used for generating the S0i3 LPI constraint list, which comes from soc_acpi_name() for each SoC. The names used for the eMMC controller do not match, which will lead to broken ACPI tables since the LPI constriant will reference an ACPI device which does not exist. Some OSes tolerate this better than others, but it should still be corrected.
TEST=build/boot google/{hatch,volteer, brya}, dump ACPI and verify no invalid device names referenced.
Change-Id: Icbc22b6b2a84bbe73f1b09083f27081612db5eba Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78825 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Eric Lai ericllai@google.com --- M src/soc/intel/alderlake/acpi/scs.asl M src/soc/intel/cannonlake/acpi/scs.asl M src/soc/intel/elkhartlake/acpi/scs.asl M src/soc/intel/jasperlake/acpi/scs.asl 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/acpi/scs.asl b/src/soc/intel/alderlake/acpi/scs.asl index aac78e8..d39c66d 100644 --- a/src/soc/intel/alderlake/acpi/scs.asl +++ b/src/soc/intel/alderlake/acpi/scs.asl @@ -18,7 +18,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name(TEMP, 0) diff --git a/src/soc/intel/cannonlake/acpi/scs.asl b/src/soc/intel/cannonlake/acpi/scs.asl index 7def761..fcadcbd 100644 --- a/src/soc/intel/cannonlake/acpi/scs.asl +++ b/src/soc/intel/cannonlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/elkhartlake/acpi/scs.asl b/src/soc/intel/elkhartlake/acpi/scs.asl index c6d71c1..3955402 100644 --- a/src/soc/intel/elkhartlake/acpi/scs.asl +++ b/src/soc/intel/elkhartlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0) diff --git a/src/soc/intel/jasperlake/acpi/scs.asl b/src/soc/intel/jasperlake/acpi/scs.asl index b58608f..491df51 100644 --- a/src/soc/intel/jasperlake/acpi/scs.asl +++ b/src/soc/intel/jasperlake/acpi/scs.asl @@ -15,7 +15,7 @@ }
/* EMMC */ - Device(PEMC) { + Device(EMMC) { Name(_ADR, 0x001A0000) Name (_DDN, "eMMC Controller") Name (TEMP, 0)