Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Maximilian Brune, Paul Menzel, Varshit Pandya.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86584?usp=email )
Change subject: soc/amd/common/block/lpc: Use ROM3 window if possible
......................................................................
Patch Set 11:
(1 comment)
File src/soc/amd/common/block/spi/mmap_boot_rom3.c:
https://review.coreboot.org/c/coreboot/+/86584/comment/d4347ae7_3417cacb?usp... :
PS11, Line 62: * 0 +------------+ ------------------------------0xFF0000000--+--------------+- rom2_start
hmm, i don't like that smmstorev2 interface design too much and i still don't think that we should o […]
Document 56780 describes the remapping for ROM3 as well.
Reading through the document it sounds remapping isn't yet supported.
You would need another valid EFS in the second 16MByte page as well as all necessary structures to boot (FMAP, CBFS, ...).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86584?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8976273cfb31765d7f893b3fc137f117c63b6553
Gerrit-Change-Number: 86584
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 31 Mar 2025 10:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de