Change in coreboot[master]: soc/amd/picasso/Makefile: use all-y for adding config.c to the build
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48313 )
Change subject: soc/amd/picasso/Makefile: use all-y for adding config.c to the build ......................................................................
soc/amd/picasso/Makefile: use all-y for adding config.c to the build
Since config.c also gets linked into verstage on PSP and not only into the stages running on the x86 cores, use all-y instead of adding config.c to all classes separately.
Change-Id: Icacb13e73e80e6f3d8c2141784702fb895daf7db Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/48313/1
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index d86d97e..d48dffd 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -10,6 +10,8 @@ subdirs-y += ../../../cpu/x86/smm subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
+all-y += config.c + bootblock-y += bootblock.c bootblock-y += aoac.c bootblock-y += southbridge.c @@ -17,7 +19,6 @@ bootblock-y += uart.c bootblock-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c bootblock-y += gpio.c -bootblock-y += config.c bootblock-y += reset.c
romstage-y += i2c.c @@ -30,11 +31,9 @@ romstage-y += aoac.c romstage-y += southbridge.c romstage-y += psp.c -romstage-y += config.c romstage-y += mrc_cache.c
verstage-y += i2c.c -verstage-y += config.c verstage-y += aoac.c verstage_x86-y += gpio.c verstage_x86-y += uart.c @@ -63,7 +62,6 @@ ramstage-y += soc_util.c ramstage-y += psp.c ramstage-y += fsp_params.c -ramstage-y += config.c ramstage-y += update_microcode.c ramstage-y += graphics.c ramstage-y += pcie_gpp.c @@ -78,7 +76,6 @@ smm-y += gpio.c smm-y += psp.c smm-y += smu.c -smm-y += config.c
CPPFLAGS_common += -I$(src)/soc/amd/picasso CPPFLAGS_common += -I$(src)/soc/amd/picasso/include
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48313 )
Change subject: soc/amd/picasso/Makefile: use all-y for adding config.c to the build ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48313 )
Change subject: soc/amd/picasso/Makefile: use all-y for adding config.c to the build ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48313 )
Change subject: soc/amd/picasso/Makefile: use all-y for adding config.c to the build ......................................................................
soc/amd/picasso/Makefile: use all-y for adding config.c to the build
Since config.c also gets linked into verstage on PSP and not only into the stages running on the x86 cores, use all-y instead of adding config.c to all classes separately.
Change-Id: Icacb13e73e80e6f3d8c2141784702fb895daf7db Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48313 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/Makefile.inc 1 file changed, 2 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index d86d97e..d48dffd 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -10,6 +10,8 @@ subdirs-y += ../../../cpu/x86/smm subdirs-$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK) += psp_verstage
+all-y += config.c + bootblock-y += bootblock.c bootblock-y += aoac.c bootblock-y += southbridge.c @@ -17,7 +19,6 @@ bootblock-y += uart.c bootblock-$(CONFIG_PICASSO_CONSOLE_UART) += uart_console.c bootblock-y += gpio.c -bootblock-y += config.c bootblock-y += reset.c
romstage-y += i2c.c @@ -30,11 +31,9 @@ romstage-y += aoac.c romstage-y += southbridge.c romstage-y += psp.c -romstage-y += config.c romstage-y += mrc_cache.c
verstage-y += i2c.c -verstage-y += config.c verstage-y += aoac.c verstage_x86-y += gpio.c verstage_x86-y += uart.c @@ -63,7 +62,6 @@ ramstage-y += soc_util.c ramstage-y += psp.c ramstage-y += fsp_params.c -ramstage-y += config.c ramstage-y += update_microcode.c ramstage-y += graphics.c ramstage-y += pcie_gpp.c @@ -78,7 +76,6 @@ smm-y += gpio.c smm-y += psp.c smm-y += smu.c -smm-y += config.c
CPPFLAGS_common += -I$(src)/soc/amd/picasso CPPFLAGS_common += -I$(src)/soc/amd/picasso/include
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Patrick Georgi (Code Review)