Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE
The platform_cfg.h under mainboard/ are legacy configuration mechanism used with AGESA family14 board. All boards advertise as PM_DESKTOP for power management profile.
Change-Id: Ic28761eb238dbbaf3e8f820a29ec64b89f12bf53 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/persimmon/platform_cfg.h M src/mainboard/elmex/pcm205400/platform_cfg.h M src/mainboard/gizmosphere/gizmo/platform_cfg.h M src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h M src/mainboard/lippert/frontrunner-af/platform_cfg.h M src/mainboard/lippert/toucan-af/platform_cfg.h M src/mainboard/pcengines/apu1/platform_cfg.h M src/southbridge/amd/cimx/sb800/fadt.c 8 files changed, 1 insertion(+), 103 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42031/1
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h index e93c306..87a5cc4 100644 --- a/src/mainboard/amd/persimmon/platform_cfg.h +++ b/src/mainboard/amd/persimmon/platform_cfg.h @@ -224,18 +224,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/elmex/pcm205400/platform_cfg.h b/src/mainboard/elmex/pcm205400/platform_cfg.h index f4a3e59..b621f60b 100644 --- a/src/mainboard/elmex/pcm205400/platform_cfg.h +++ b/src/mainboard/elmex/pcm205400/platform_cfg.h @@ -222,18 +222,4 @@ */ //#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/gizmosphere/gizmo/platform_cfg.h b/src/mainboard/gizmosphere/gizmo/platform_cfg.h index f4f713b..2ea529f 100644 --- a/src/mainboard/gizmosphere/gizmo/platform_cfg.h +++ b/src/mainboard/gizmosphere/gizmo/platform_cfg.h @@ -229,18 +229,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h index 8bdaf7e..bacb7b1 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h +++ b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/lippert/frontrunner-af/platform_cfg.h b/src/mainboard/lippert/frontrunner-af/platform_cfg.h index ad60ef2..7d4f1f9 100644 --- a/src/mainboard/lippert/frontrunner-af/platform_cfg.h +++ b/src/mainboard/lippert/frontrunner-af/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/lippert/toucan-af/platform_cfg.h b/src/mainboard/lippert/toucan-af/platform_cfg.h index b57e195..b029efb 100644 --- a/src/mainboard/lippert/toucan-af/platform_cfg.h +++ b/src/mainboard/lippert/toucan-af/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/pcengines/apu1/platform_cfg.h b/src/mainboard/pcengines/apu1/platform_cfg.h index 63a3d5a..6087b15 100644 --- a/src/mainboard/pcengines/apu1/platform_cfg.h +++ b/src/mainboard/pcengines/apu1/platform_cfg.h @@ -198,20 +198,6 @@ */ #define GEC_CONFIG 0
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - /** * @def USB_RX_MODE * 0x00 - leave Cg2Pll voltage at default value (1.222V) diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c index d2339c6..153becc 100644 --- a/src/southbridge/amd/cimx/sb800/fadt.c +++ b/src/southbridge/amd/cimx/sb800/fadt.c @@ -23,10 +23,6 @@ #endif #endif
-#ifndef FADT_PM_PROFILE - #define FADT_PM_PROFILE PM_UNSPECIFIED -#endif - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. @@ -59,7 +55,7 @@ fadt->dsdt = (uintptr_t)dsdt;
fadt->reserved = 0; /* reserved, should be 0 ACPI 3.0 */ - fadt->preferred_pm_profile = FADT_PM_PROFILE; + fadt->preferred_pm_profile = PM_DESKTOP; fadt->sci_int = 9; /* HUDSON 1 - IRQ 09 - ACPI SCI */
val = PM1_EVT_BLK_ADDRESS;
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 1:
Should `src/mainboard/asrock/e350m1/platform_cfg.h` be removed too?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 1: Code-Review-1
Patch Set 1:
Should `src/mainboard/asrock/e350m1/platform_cfg.h` be removed too?
Indeed, marking with -1 only so that it sticks out.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Patch Set 1:
Should `src/mainboard/asrock/e350m1/platform_cfg.h` be removed too?
Indeed, marking with -1 only so that it sticks out.
What is there to remove? But right, for asrock/e350m1 this changes from PM_UNSPECIFIED to PM_DESKTOP and should be mentioned. Then again, the whole concept of sb/ assigning preferred_pm_profile is somewhat wrong.
CB:42032 for further discussion about this.
Hello build bot (Jenkins), Michał Żygowski, Angel Pons, Felix Held, Piotr Król,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42031
to look at the new patch set (#2).
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE
The platform_cfg.h files under mainboard/ are a legacy configuration mechanism used with AGESA family14 boards.
With this change following boards will have FADT preferred_pm_profile changed from PM_UNSPECIFIED to PM_DESKTOP:
amd/inaqua amd/south_station amd/union_station asrock/e350m1
Change-Id: Ic28761eb238dbbaf3e8f820a29ec64b89f12bf53 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/persimmon/platform_cfg.h M src/mainboard/elmex/pcm205400/platform_cfg.h M src/mainboard/gizmosphere/gizmo/platform_cfg.h M src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h M src/mainboard/lippert/frontrunner-af/platform_cfg.h M src/mainboard/lippert/toucan-af/platform_cfg.h M src/mainboard/pcengines/apu1/platform_cfg.h M src/southbridge/amd/cimx/sb800/fadt.c 8 files changed, 1 insertion(+), 103 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42031/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 2: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42031 )
Change subject: mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE ......................................................................
mb,sb/amd/cimx/sb800: Remove FADT_PM_PROFILE
The platform_cfg.h files under mainboard/ are a legacy configuration mechanism used with AGESA family14 boards.
With this change following boards will have FADT preferred_pm_profile changed from PM_UNSPECIFIED to PM_DESKTOP:
amd/inaqua amd/south_station amd/union_station asrock/e350m1
Change-Id: Ic28761eb238dbbaf3e8f820a29ec64b89f12bf53 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42031 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/mainboard/amd/persimmon/platform_cfg.h M src/mainboard/elmex/pcm205400/platform_cfg.h M src/mainboard/gizmosphere/gizmo/platform_cfg.h M src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h M src/mainboard/lippert/frontrunner-af/platform_cfg.h M src/mainboard/lippert/toucan-af/platform_cfg.h M src/mainboard/pcengines/apu1/platform_cfg.h M src/southbridge/amd/cimx/sb800/fadt.c 8 files changed, 1 insertion(+), 103 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h index e93c306..87a5cc4 100644 --- a/src/mainboard/amd/persimmon/platform_cfg.h +++ b/src/mainboard/amd/persimmon/platform_cfg.h @@ -224,18 +224,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/elmex/pcm205400/platform_cfg.h b/src/mainboard/elmex/pcm205400/platform_cfg.h index f4a3e59..b621f60b 100644 --- a/src/mainboard/elmex/pcm205400/platform_cfg.h +++ b/src/mainboard/elmex/pcm205400/platform_cfg.h @@ -222,18 +222,4 @@ */ //#define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/gizmosphere/gizmo/platform_cfg.h b/src/mainboard/gizmosphere/gizmo/platform_cfg.h index f4f713b..2ea529f 100644 --- a/src/mainboard/gizmosphere/gizmo/platform_cfg.h +++ b/src/mainboard/gizmosphere/gizmo/platform_cfg.h @@ -229,18 +229,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h index 8bdaf7e..bacb7b1 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h +++ b/src/mainboard/jetway/nf81-t56n-lf/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif /* _PLATFORM_CFG_H_ */ diff --git a/src/mainboard/lippert/frontrunner-af/platform_cfg.h b/src/mainboard/lippert/frontrunner-af/platform_cfg.h index ad60ef2..7d4f1f9 100644 --- a/src/mainboard/lippert/frontrunner-af/platform_cfg.h +++ b/src/mainboard/lippert/frontrunner-af/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/lippert/toucan-af/platform_cfg.h b/src/mainboard/lippert/toucan-af/platform_cfg.h index b57e195..b029efb 100644 --- a/src/mainboard/lippert/toucan-af/platform_cfg.h +++ b/src/mainboard/lippert/toucan-af/platform_cfg.h @@ -226,18 +226,4 @@ */ #define AZALIA_OEM_VERB_TABLE (&codec_tablelist[0])
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - #endif diff --git a/src/mainboard/pcengines/apu1/platform_cfg.h b/src/mainboard/pcengines/apu1/platform_cfg.h index 63a3d5a..6087b15 100644 --- a/src/mainboard/pcengines/apu1/platform_cfg.h +++ b/src/mainboard/pcengines/apu1/platform_cfg.h @@ -198,20 +198,6 @@ */ #define GEC_CONFIG 0
-/* set up an ACPI preferred power management profile */ -/* from acpi.h - * PM_UNSPECIFIED = 0, - * PM_DESKTOP = 1, - * PM_MOBILE = 2, - * PM_WORKSTATION = 3, - * PM_ENTERPRISE_SERVER = 4, - * PM_SOHO_SERVER = 5, - * PM_APPLIANCE_PC = 6, - * PM_PERFORMANCE_SERVER = 7, - * PM_TABLET = 8 - */ -#define FADT_PM_PROFILE 1 - /** * @def USB_RX_MODE * 0x00 - leave Cg2Pll voltage at default value (1.222V) diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c index d2339c6..153becc 100644 --- a/src/southbridge/amd/cimx/sb800/fadt.c +++ b/src/southbridge/amd/cimx/sb800/fadt.c @@ -23,10 +23,6 @@ #endif #endif
-#ifndef FADT_PM_PROFILE - #define FADT_PM_PROFILE PM_UNSPECIFIED -#endif - /* * Reference section 5.2.9 Fixed ACPI Description Table (FADT) * in the ACPI 3.0b specification. @@ -59,7 +55,7 @@ fadt->dsdt = (uintptr_t)dsdt;
fadt->reserved = 0; /* reserved, should be 0 ACPI 3.0 */ - fadt->preferred_pm_profile = FADT_PM_PROFILE; + fadt->preferred_pm_profile = PM_DESKTOP; fadt->sci_int = 9; /* HUDSON 1 - IRQ 09 - ACPI SCI */
val = PM1_EVT_BLK_ADDRESS;
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Michał Żygowski (Code Review)
-
Paul Menzel (Code Review)