Patch Set 1: Code-Review-1

Patch Set 1:

Should `src/mainboard/asrock/e350m1/platform_cfg.h` be removed too?

Indeed, marking with -1 only so that it sticks out.

What is there to remove? But right, for asrock/e350m1 this changes from PM_UNSPECIFIED to PM_DESKTOP and should be mentioned. Then again, the whole concept of sb/ assigning preferred_pm_profile is somewhat wrong.

CB:42032 for further discussion about this.

View Change

To view, visit change 42031. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic28761eb238dbbaf3e8f820a29ec64b89f12bf53
Gerrit-Change-Number: 42031
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 07 Jun 2020 09:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment