[S] Change in coreboot[master]: mb/google/myst: Enable eSPI SCI events - coreboot-gerrit

7 Apr 2023


      Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74101 )
Change subject: mb/google/myst: Enable eSPI SCI events
......................................................................
Patch Set 20: Code-Review+2
(1 comment)
File src/mainboard/google/myst/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74101/comment/57a6ca80_1a352048 
PS19, Line 44: 	pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1)));
...
Does that mean the line itself is unnecessary? […]
oh I mean the TODO.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b
Gerrit-Change-Number: 74101
Gerrit-PatchSet: 20
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Fri, 07 Apr 2023 00:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment