Attention is currently required from: Nick Vaccaro, Pavan Holla, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
Change subject: Hide typec ACPI device if UCSI is supported ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81967/comment/892ee6c1_5ae8aab6 : PS2, Line 7: Hide typec ACPI device if UCSI is supported Nit: `ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled.`
https://review.coreboot.org/c/coreboot/+/81967/comment/b8062de4_7f8a545b : PS2, Line 9: remove We are not removing. Rather we are not filling the TypeC ACPI device when UCSI is enabled. So I will rephrase the commit message accordingly.
https://review.coreboot.org/c/coreboot/+/81967/comment/e8f4b90a_10361f0a : PS2, Line 17: b/333074788 and https://crrev.com/c/5421069 track the corresponding EC : change to add CBI. : https://crrev.com/c/5416841 is the change for adding the feature flag These links probably are access controlled and hence the community may not have access to it. You can remove them.
https://review.coreboot.org/c/coreboot/+/81967/comment/d612e29a_7eb233d0 : PS2, Line 23: Cq-Depend: chromium:5416841
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/81967/comment/147f2faa_452eb01a : PS2, Line 161: /* UCSI implementations do not require an ACPI device : * with mux info since the linux kernel doesn't set : * the muxes. */ Nit: Coreboot allows 96 chars per line. Also here is the guideline regarding multi-line comments - https://doc.coreboot.org/contributing/coding_style.html#commenting
Specifically this can be updated as:
``` /* UCSI implementations do not require an ACPI device with mux info since the linux kernel doesn't set the muxes. */ ```