Attention is currently required from: Nick Vaccaro, Pavan Holla, Shelley Chen.
5 comments:
Commit Message:
Patch Set #2, Line 7: Hide typec ACPI device if UCSI is supported
Nit:
`ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled.`
Patch Set #2, Line 9: remove
We are not removing. Rather we are not filling the TypeC ACPI device when UCSI is enabled. So I will rephrase the commit message accordingly.
b/333074788 and https://crrev.com/c/5421069 track the corresponding EC
change to add CBI.
https://crrev.com/c/5416841 is the change for adding the feature flag
These links probably are access controlled and hence the community may not have access to it. You can remove them.
Cq-Depend: chromium:5416841
File src/ec/google/chromeec/ec_acpi.c:
/* UCSI implementations do not require an ACPI device
* with mux info since the linux kernel doesn't set
* the muxes. */
Nit: Coreboot allows 96 chars per line. Also here is the guideline regarding multi-line comments - https://doc.coreboot.org/contributing/coding_style.html#commenting
Specifically this can be updated as:
```
/* UCSI implementations do not require an ACPI device with mux info since the
linux kernel doesn't set the muxes. */
```
To view, visit change 81967. To unsubscribe, or for help writing mail filters, visit settings.