Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 32:
(1 comment)
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar... File src/mainboard/google/cheza/mainboard.c:
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar... PS24, Line 42: i2c_init(12, 400 * KHz, 1);
According to our discussion, qup enum should be defined in clock driver and qup drivers should inclu […]
I don't understand the problem here to be honest. The QUPs have a well-known numbering and it has to be defined somewhere. I would say that numbering clearly belongs more to the QUPs than to the clock controller, although the clock controller also uses it of course. If it's a patch dependency problem, it's fine to add the qcom_qup_se.h file in the clock patch with just the enum definition and nothing else, and then have a later QUP patch to add the other stuff.
-
Julius Werner (Code Review)