Attention is currently required from: Eric Lai, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85934?usp=email )
Change subject: soc/intel/pantherlake: Refactor FSP log level control
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/pantherlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85934/comment/1a8c47e0_7c6fb393?usp... :
PS2, Line 313: if (is_enabled) {
: enum fsp_log_level log_level = fsp_map_console_log_level();
: fsp_set_debug_level(m_cfg, log_level, log_level);
: } else {
: /* Disable Serial/MRC debug message */
: fsp_set_debug_level(m_cfg, 0, 0);
: }
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85934?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6efd6a0ea006b4013dce1c8849b7dbbd4ea5e1dc
Gerrit-Change-Number: 85934
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 13 Jan 2025 10:55:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com