Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51251 )
Change subject: soc/intel/common/block/cpu: Update the comments ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/51251/comment/d67194b6_f8335aba PS2, Line 418: back up the number of ways of LLC to protect from eviction
You are right on the logic but DCACHE_RAM_SIZE is too big i believe frim way size. In ADL, we have increase DCACHE_RAM_SIZE to 768KB if still DCACHE_RAM_SIZE is lesser then i doubt about case for earlier generations.
Do you have `INTEL_CAR_NEM_ENHANCED` selected? I see that ADL Kconfig does not select `INTEL_CAR_NEM_ENHANCED`. That might explain why you don't see the hang with your jmp if you are testing this on ADL.
Here you go 😊 https://review.coreboot.org/c/coreboot/+/48345/4/src/soc/intel/alderlake/Kco...
i think the problem is that, i wanted to remove the mask calculation from here and add all mask calculation in below code ... I will clean up the code.
I am still not clear on what problem you are trying to solve here. If you upload a patch with context, it might be easier to understand.
Sure, i will
-
Subrata Banik (Code Review)