Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3984
-gerrit
commit fec4f868b1d3915c80d2603b675d88a520b5de7c Author: Paul Menzel paulepanter@users.sourceforge.net Date: Mon Oct 21 21:22:09 2013 +0200
northbridge/intel/i945/raminit.c: Remove set but unused variable `reg16`
Removing `-Wno-unused-but-set-variable` from `CFLAGS` results in the following error.
CC northbridge/intel/i945/raminit.romstage.o src/northbridge/intel/i945/raminit.c: In function 'sdram_detect_cas_latency_and_ram_speed': src/northbridge/intel/i945/raminit.c:497:6: error: variable 'lowest_common_cas' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/i945/raminit.c: In function 'sdram_program_pll_settings': src/northbridge/intel/i945/raminit.c:1955:15: error: variable 'reg16' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors
The variable is declared as `volatile`, but as it is not read anywhere it can be removed.
Change-Id: Id4a758644a7b799e7662113c07d395e053525934 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/northbridge/intel/i945/raminit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index b50f1d8..512d8e9 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -1952,8 +1952,6 @@ static void sdram_set_channel_mode(struct sys_info *sysinfo)
static void sdram_program_pll_settings(struct sys_info *sysinfo) { - volatile u16 reg16; - MCHBAR32(PLLMON) = 0x80800000;
sysinfo->fsb_frequency = fsbclk(); @@ -1970,7 +1968,7 @@ static void sdram_program_pll_settings(struct sys_info *sysinfo)
MCHBAR16(CPCTL) &= ~(1 << 11);
- reg16 = MCHBAR16(CPCTL); /* Read back register to activate settings */ + MCHBAR16(CPCTL); /* Read back register to activate settings */ }
static void sdram_program_graphics_frequency(struct sys_info *sysinfo)