Attention is currently required from: Michał Żygowski, Piotr Król. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50656 )
Change subject: AGESA fam14 boards: Drop _SI scope with _SST in ASL ......................................................................
AGESA fam14 boards: Drop _SI scope with _SST in ASL
Change-Id: Ieb2f7a6b2721ddeef6945c3e0a0f4cc5627dd533 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/mainboard/amd/inagua/acpi/mainboard.asl M src/mainboard/amd/inagua/dsdt.asl D src/mainboard/amd/persimmon/acpi/mainboard.asl M src/mainboard/amd/persimmon/dsdt.asl D src/mainboard/amd/south_station/acpi/mainboard.asl M src/mainboard/amd/south_station/dsdt.asl D src/mainboard/amd/union_station/acpi/mainboard.asl M src/mainboard/amd/union_station/dsdt.asl D src/mainboard/asrock/e350m1/acpi/mainboard.asl M src/mainboard/asrock/e350m1/dsdt.asl D src/mainboard/elmex/pcm205400/acpi/mainboard.asl M src/mainboard/elmex/pcm205400/dsdt.asl D src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl D src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl D src/mainboard/pcengines/apu1/acpi/mainboard.asl M src/mainboard/pcengines/apu1/dsdt.asl 19 files changed, 0 insertions(+), 122 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/50656/1
diff --git a/src/mainboard/amd/inagua/acpi/mainboard.asl b/src/mainboard/amd/inagua/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/amd/inagua/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl index af83ea4..834a2cf 100644 --- a/src/mainboard/amd/inagua/dsdt.asl +++ b/src/mainboard/amd/inagua/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/amd/persimmon/acpi/mainboard.asl b/src/mainboard/amd/persimmon/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/amd/persimmon/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl index af83ea4..834a2cf 100644 --- a/src/mainboard/amd/persimmon/dsdt.asl +++ b/src/mainboard/amd/persimmon/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/amd/south_station/acpi/mainboard.asl b/src/mainboard/amd/south_station/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/amd/south_station/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl index af83ea4..834a2cf 100644 --- a/src/mainboard/amd/south_station/dsdt.asl +++ b/src/mainboard/amd/south_station/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/amd/union_station/acpi/mainboard.asl b/src/mainboard/amd/union_station/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/amd/union_station/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl index af83ea4..834a2cf 100644 --- a/src/mainboard/amd/union_station/dsdt.asl +++ b/src/mainboard/amd/union_station/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/asrock/e350m1/acpi/mainboard.asl b/src/mainboard/asrock/e350m1/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/asrock/e350m1/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl index 4f76658..2267280 100644 --- a/src/mainboard/asrock/e350m1/dsdt.asl +++ b/src/mainboard/asrock/e350m1/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/elmex/pcm205400/acpi/mainboard.asl b/src/mainboard/elmex/pcm205400/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/elmex/pcm205400/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/elmex/pcm205400/dsdt.asl b/src/mainboard/elmex/pcm205400/dsdt.asl index af83ea4..834a2cf 100644 --- a/src/mainboard/elmex/pcm205400/dsdt.asl +++ b/src/mainboard/elmex/pcm205400/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl b/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/gizmosphere/gizmo/dsdt.asl b/src/mainboard/gizmosphere/gizmo/dsdt.asl index adcd64f..ea60c1c 100644 --- a/src/mainboard/gizmosphere/gizmo/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl index cd792a7..5feb9f2 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl" diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index cbb8ced..014ea08 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -724,10 +724,5 @@ Name(_STA, 0x0B) /* sata is invisible */ } } /* End _SB scope */ - - Scope(_SI) { - Method(_SST, 1) { - } - } /* End Scope SI */ } /* End of ASL file */ diff --git a/src/mainboard/pcengines/apu1/acpi/mainboard.asl b/src/mainboard/pcengines/apu1/acpi/mainboard.asl deleted file mode 100644 index b7b630a..0000000 --- a/src/mainboard/pcengines/apu1/acpi/mainboard.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl index 327570d..f74bc59 100644 --- a/src/mainboard/pcengines/apu1/dsdt.asl +++ b/src/mainboard/pcengines/apu1/dsdt.asl @@ -13,8 +13,6 @@ { /* Start of ASL file */ #include <acpi/dsdt_top.asl>
- #include "acpi/mainboard.asl" - #include <cpu/amd/agesa/family14/acpi/cpu.asl>
#include "acpi/routing.asl"
-
Kyösti Mälkki (Code Review)