Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33948
Change subject: util/nvramtool: Make internal function static ......................................................................
util/nvramtool: Make internal function static
This function is only used in this file, so it can be made static.
Change-Id: I90e673da91eb926424d1730c268860da7fa1627b Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/nvramtool/accessors/layout-bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/33948/1
diff --git a/util/nvramtool/accessors/layout-bin.c b/util/nvramtool/accessors/layout-bin.c index 8cf29d8..baada27 100644 --- a/util/nvramtool/accessors/layout-bin.c +++ b/util/nvramtool/accessors/layout-bin.c @@ -89,7 +89,7 @@ process_layout(); }
-int write_cmos_layout_bin(FILE *f) +static int write_cmos_layout_bin(FILE *f) { const cmos_entry_t *cmos_entry; const cmos_enum_t *cmos_enum;
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33948 )
Change subject: util/nvramtool: Make internal function static ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33948 )
Change subject: util/nvramtool: Make internal function static ......................................................................
util/nvramtool: Make internal function static
This function is only used in this file, so it can be made static.
Change-Id: I90e673da91eb926424d1730c268860da7fa1627b Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33948 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M util/nvramtool/accessors/layout-bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/util/nvramtool/accessors/layout-bin.c b/util/nvramtool/accessors/layout-bin.c index 8cf29d8..baada27 100644 --- a/util/nvramtool/accessors/layout-bin.c +++ b/util/nvramtool/accessors/layout-bin.c @@ -89,7 +89,7 @@ process_layout(); }
-int write_cmos_layout_bin(FILE *f) +static int write_cmos_layout_bin(FILE *f) { const cmos_entry_t *cmos_entry; const cmos_enum_t *cmos_enum;