Attention is currently required from: Tim Wawrzynczak, Felix Held.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63137 )
Change subject: mb/google/brya/variants/crota: Add memory config for crota
......................................................................
Patch Set 3:
(5 comments)
File src/mainboard/google/brya/variants/crota/memory.c:
https://review.coreboot.org/c/coreboot/+/63137/comment/aa697402_dd159765
PS2, Line 74: __weak
remove this
Done.
https://review.coreboot.org/c/coreboot/+/63137/comment/e98a3ef7_9f558c1a
PS2, Line 79: __weak
remove this
Done.
https://review.coreboot.org/c/coreboot/+/63137/comment/04c16180_21afd84c
PS2, Line 98: __weak
remove this
Done.
https://review.coreboot.org/c/coreboot/+/63137/comment/94d92835_06a053c5
PS2, Line 104: __weak
remove this
Done.
https://review.coreboot.org/c/coreboot/+/63137/comment/0c80d425_c6fdc107
PS2, Line 104: void __weak variant_get_spd_info(struct mem_spd *spd_info)
: {
: spd_info->topo = MEM_TOPO_MEMORY_DOWN;
: spd_info->cbfs_index = variant_memory_sku();
: }
I don't think this override is required?
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I981d2cd6feafee8c10ec9724a3dec9a23ba0ddd7
Gerrit-Change-Number: 63137
Gerrit-PatchSet: 3
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Jesper Lin
jesper_lin@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 29 Mar 2022 01:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment