Attention is currently required from: Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70164 )
Change subject: mb/google/herobrine: Mask out upper bits from sku_id()
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70164/comment/10f1937b_197c89f5
PS2, Line 95: bits
pins
Done
https://review.coreboot.org/c/coreboot/+/70164/comment/9374d9b6_144b292c
PS2, Line 98: uint32_t sku_bits_mask = 0x1f;
I would maybe just make it 0xff to have a cleaner boundary, that way we have some room to add a 4th […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e786ec392b5e1484cb2ff6d83a8d4fdd698950c
Gerrit-Change-Number: 70164
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 30 Nov 2022 00:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment