Attention is currently required from: Jason Glenesk, Mathew King, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50573 )
Change subject: soc/amd/cezanne/acpi: Add MMIO devices
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/acpi/mmio.asl:
https://review.coreboot.org/c/coreboot/+/50573/comment/3c444d29_cc5519f3
PS2, Line 315: Package () { "is-rv", 1 },
Agreed. […]
Agreed. I think we should have allocated a new HID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddfb975e9292785d0951dd7bb31c1997d2185abd
Gerrit-Change-Number: 50573
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 12 Feb 2021 22:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment