Attention is currently required from: Bora Guvendik, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik.
Li1 Feng has posted comments on this change by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/86005?usp=email )
Change subject: mb/google/fatcat/var/fatcat: disable ISH UART0 RX pin
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86005/comment/24a01272_f027f20c?usp... :
PS2, Line 7: fatcat-ish
Please use a longer prefix. `git log --oneline` should show you kind of a template.
Done
https://review.coreboot.org/c/coreboot/+/86005/comment/4c5d200e_bc3a0174?usp... :
PS2, Line 11: causing ISH low power mode failure
How is this failure detected?
ISH console log shows it hang during boot up; not able to register with cros_ec.
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/86005/comment/ab287523_b0bfecee?usp... :
PS2, Line 432: /* GPP_D05: ISH_UART0_RXD */
: PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2),
We still have ISH log, just console doesn't accept input. […]
Added this to comment. In any case, like for debug purpose, if we want to input to console working, we can revert this change(better be local change) and make sure ISH DIP switch setting is ON.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic84f8ead6a1fd056e649edbb1471bcb913a0a09a
Gerrit-Change-Number: 86005
Gerrit-PatchSet: 5
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 29 Jan 2025 02:31:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Li1 Feng
li1.feng@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org