Attention is currently required from: Eric Lai, Jon Murphy, Karthik Ramasubramanian, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75583?usp=email )
Change subject: mb/google/myst: Add PCIe shutdown workaround
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/myst/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/75583/comment/6869edfb_3c7a8633 :
PS2, Line 56: .turn_off_unused_lanes = true,
This is a workaround and it's working. We have a bug to track getting it fixed. […]
What are the differences between the two in terms of unintended side effects? My preference would be to make changes that are as specific as possible, to reduce introducing unrelated behavior changes that could take additional time to debug.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf0aca329f05f15a3ce9edfa6a0e782c2edccabe
Gerrit-Change-Number: 75583
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 21:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment