Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36783 )
Change subject: nb/intel/sandybridge: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 2:
(1 comment)
This calls the weak mainboard_pch_enable_lpc() in bootblock... Ok,
I see now it is fixed later. But.. are weak functions really worth
the hassle?! half of the review time wasted with wild-goose chasing.
https://review.coreboot.org/c/coreboot/+/36783/2/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36783/2/src/southbridge/intel/bd82x...
PS2, Line 39: #if 0
This is so odd ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d0ba29111a5df6f19033f5ce95adcc0d9adc1fd
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 16 Nov 2019 15:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment