Change in coreboot[master]: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS)

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Tony Huang (Code Review)

6 Oct 2020 6 Oct '20

2:50 a.m.

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS)

Enable ALS ACPI devices for dooly.

BUG=b:168426118 BRANCH=puff TEST=Ensure that ALS devices are enabled in ACPI tables.

Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/46061/1

diff --git a/src/mainboard/google/hatch/variants/dooly/include/variant/ec.h b/src/mainboard/google/hatch/variants/dooly/include/variant/ec.h index 59fb378..7d280c6 100644 --- a/src/mainboard/google/hatch/variants/dooly/include/variant/ec.h +++ b/src/mainboard/google/hatch/variants/dooly/include/variant/ec.h @@ -5,4 +5,7 @@

#include <puff/ec.h>

+/* Enable EC backed ALS device in ACPI */ +#define EC_ENABLE_ALS_DEVICE + #endif

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Sam McNally (Code Review)

6 Oct 6 Oct

3:37 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 06 Oct 2020 03:37:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

12 Oct 12 Oct

2:40 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 12 Oct 2020 02:40:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tony Huang (Code Review)

8:04 a.m.

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1:

Hi Sam, Edward,

Could you please help merge this CL?

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 12 Oct 2020 08:04:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tony Huang (Code Review)

13 Oct 13 Oct

6:23 a.m.

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1:

Please help submit this CL. Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 13 Oct 2020 06:23:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tony Huang (Code Review)

14 Oct 14 Oct

12:54 a.m.

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

Patch Set 1:

Hi Edward, Could you please help merge this change? Thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 14 Oct 2020 00:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

2:22 a.m.

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46061 )

Change subject: mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS) ......................................................................

mb/google/puff/var/dooly: Enable Ambient Light Sensor (ALS)

Enable ALS ACPI devices for dooly.

BUG=b:168426118 BRANCH=puff TEST=Ensure that ALS devices are enabled in ACPI tables.

Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46061 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/dooly/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved

#include <puff/ec.h>

+/* Enable EC backed ALS device in ACPI */ +#define EC_ENABLE_ALS_DEVICE + #endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/46061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd44d6ae1e7b62939fdfc3a0ab01924d2c1714aa Gerrit-Change-Number: 46061 Gerrit-PatchSet: 2 Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1313

days inactive

1321

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Edward O'Callaghan (Code Review)
Sam McNally (Code Review)
Tony Huang (Code Review)