Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Ronak Kanabar.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: drivers/intel/fsp2_0: Add low battery indicator screen ......................................................................
Patch Set 9:
(2 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/86225/comment/2d7807d8_2384b2db?usp... : PS8, Line 527: select BMP_LOGO
This should probably be a `depends on` instead?
Acknowledged
File src/vendorcode/google/chromeos/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86225/comment/5be20275_f511815f?usp... : PS8, Line 45: low_battery.bmp,CONFIG_PLATFORM_LOW_BATTERY_INDICATOR_LOGO_PATH))
This should go either in `fsp2_0/Makefile.mk` or in `src/lib/Makefile.mk` (because `bmp_logo.c` is there... actually, it's quite weird that we don't have a rule adding a `logo.bmp` file when `HAVE_CUSTOM_BMP_LOGO` is false, that should probably go in there too).
not sure if I understand the later one about not having a rule
inside fsp2_0/makefile.mk ``` # Add logo to the cbfs image ifneq ($(CONFIG_HAVE_CUSTOM_BMP_LOGO),y) cbfs-files-$(CONFIG_BMP_LOGO) += logo.bmp logo.bmp-file := $(call strip_quotes,$(CONFIG_FSP2_0_LOGO_FILE_NAME)) logo.bmp-type := raw ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) logo.bmp-compression := LZMA else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) logo.bmp-compression := LZ4 endif endif ```
-
Subrata Banik (Code Review)