Change in coreboot[master]: mb/google/octopus/var/fleex: Add ssfc codec cs42l42 support - coreboot-gerrit

20 Apr 2021


      Attention is currently required from: Marco Chen, EricR Lai.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52363 )
Change subject: mb/google/octopus/var/fleex: Add ssfc codec cs42l42 support
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/52363/comment/4efb408b_b1d4d939 
PS7, Line 21: /* GPIO_144 -- Codec reset pin. */
            : 	PAD_CFG_GPO(GPIO_144, 1, PWROK),
Is it ok to keep this GPIO high for all fleex variants?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52363
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1571003f8b272a573e6ab9fb525f17659bae8c4c
Gerrit-Change-Number: 52363
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Marco Chen marcochen@google.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 20 Apr 2021 15:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment