Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ......................................................................
Patch Set 8:
(4 comments)
File src/soc/mediatek/mt8196/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/85126/comment/06ba955b_6ea58913?usp... : PS6, Line 645: u32 sys_timer_latch_l[16];
Array usage is wrong. Should be a single array of structs of 2 u32 members.
Done
File src/soc/mediatek/mt8196/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/878ddb63_057669b8?usp... : PS6, Line 188: ret |= pmif_check_vlpck_freq(PMIF_VLPCK_TARGET_FREQ_MHZ);
extra space after =
Done
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/9485da14_49b13632?usp... : PS7, Line 183: __func__, dev->slvid, rdata);
Align
Done
https://review.coreboot.org/c/coreboot/+/85126/comment/c27443c6_5ea20e26?usp... : PS7, Line 216: cali_data[i].dly, cali_data[i].pol, read32(®->mst_sampl));
Align
Done