Attention is currently required from: Simon Chou, Daocheng Bu, Johnny Lin, Subrata Banik, Arthur Heymans, Ray Han Lim Ng, Andrey Petrov.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71950 )
Change subject: drivers/intel/fsp2_0: Add saving MRC data after FSP-S option
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/71950/comment/3e03a276_a8687b8d
PS2, Line 390: MRC data compression/decompression can be done faster
: in memory than CAR due to larger data size.
This is not true. The problem is that RAM is not cached when the MRC runs. […]
When MRC runs, the DRAM is not working yet. How would WB caching help?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bab0c5004e717e842b484c89187e8c0b9c2b3eb
Gerrit-Change-Number: 71950
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: Ray Han Lim Ng
ray.han.lim.ng@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ray Han Lim Ng
ray.han.lim.ng@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 22:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment