[M] Change in coreboot[master]: cpu/intel/model_2065x: Don't use a magic APIC - coreboot-gerrit

11 Nov 2022


      Attention is currently required from: Arthur Heymans, Stefan Ott, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59315 )
Change subject: cpu/intel/model_2065x: Don't use a magic APIC
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/cpu/intel/model_2065x/model_2065x_init.c:
https://review.coreboot.org/c/coreboot/+/59315/comment/152033cb_12b2c50f 
PS11, Line 25: 	struct cpu_intel_model_2065x_config *conf = dev->bus->dev->chip_info;
Can any of these dereferences result in undefined behavior? Or are these pointers never NULL?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59315
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296631511b0e31b0ed43ca8193552483bdab4482
Gerrit-Change-Number: 59315
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Stefan Ott coreboot@desire.ch
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Stefan Ott coreboot@desire.ch
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 15:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment