Change in coreboot[master]: [TEST]: drawcia: set PL1 to higher value

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44803 )

Change subject: [TEST]: drawcia: set PL1 to higher value
......................................................................

[TEST]: drawcia: set PL1 to higher value

Set PL1 to higher value

Change-Id: Ibc0b2d2cedc68ab367bf0947034e048fbbfc0841
Signed-off-by: Sumeet Pawnikar 
---
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/44803/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
index ee95332..15e09db 100644
--- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
@@ -40,7 +40,7 @@
    }"

register "power_limits_config" = "{
-		.tdp_pl1_override = 6,
+		.tdp_pl1_override = 8,
    	.tdp_pl2_override = 15,
    }"

@@ -69,12 +69,12 @@

register "controls.power_limits.pl1" = "{
    				.min_power = 4800,
-					.max_power = 6000,
+					.max_power = 8000,
    				.time_window_min = 1 * MSECS_PER_SEC,
    				.time_window_max = 1 * MSECS_PER_SEC,
    				.granularity = 200,}"
    			register "controls.power_limits.pl2" = "{
-					.min_power = 6000,
+					.min_power = 8000,
    				.max_power = 15000,
    				.time_window_min = 1 * MSECS_PER_SEC,
    				.time_window_max = 1 * MSECS_PER_SEC,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44803 )

Change subject: [TEST]: drawcia: set PL1 to higher value
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44803/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44803/1//COMMIT_MSG@7 
PS1, Line 7: [TEST]: drawcia: set PL1 to higher value
> Increase PL1 from 6 W to 8 W

(Is it Watts?)

https://review.coreboot.org/c/coreboot/+/44803/1//COMMIT_MSG@10 
PS1, Line 10: 
Where did you get the value from, and what does it improve?

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44803 )

Change subject: [TEST]: drawcia: set PL1 to higher value
......................................................................

Abandoned

This was TEST patch.