Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55065 )
Change subject: drivers/amd/agesa/romstage.c: Remove lapic_id check ......................................................................
drivers/amd/agesa/romstage.c: Remove lapic_id check
The APs don't execute this codepath but ap_romstage_main().
Change-Id: If884001bc8c5363efbbf00422a9a700896318f7b Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/55065 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/amd/agesa/romstage.c 1 file changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/amd/agesa/romstage.c b/src/drivers/amd/agesa/romstage.c index b8f38ce..871054b 100644 --- a/src/drivers/amd/agesa/romstage.c +++ b/src/drivers/amd/agesa/romstage.c @@ -36,22 +36,18 @@ struct postcar_frame pcf; struct sysinfo romstage_state; struct sysinfo *cb = &romstage_state; - unsigned int initial_apic_id = initial_lapicid(); int cbmem_initted = 0;
fill_sysinfo(cb);
- if (initial_apic_id == 0) { + timestamp_add_now(TS_START_ROMSTAGE);
- timestamp_add_now(TS_START_ROMSTAGE); + board_BeforeAgesa(cb);
- board_BeforeAgesa(cb); - - console_init(); - } + console_init();
printk(BIOS_DEBUG, "APIC %02u: CPU Family_Model = %08x\n", - initial_apic_id, cpuid_eax(1)); + initial_lapicid(), cpuid_eax(1));
set_ap_entry_ptr(ap_romstage_main);