Change in coreboot[master]: driver/i2c/max98390: Correct variable name .acpi_fill_ssdt

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

shkim (Code Review)

18 May 2020 18 May '20

6:40 a.m.

Hello SH Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/41496

to review the following change.

Change subject: driver/i2c/max98390: Correct variable name .acpi_fill_ssdt ......................................................................

driver/i2c/max98390: Correct variable name .acpi_fill_ssdt

Fix coreboot build error with adding this driver

BUG=b:149443429 BRANCH=None TEST=built without errors

Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c --- M src/drivers/i2c/max98390/max98390.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41496/1

diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index c8d7699..01a1c49 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -86,7 +86,7 @@ .read_resources = noop_read_resources, .set_resources = noop_set_resources, .acpi_name = max98390_acpi_name, - .acpi_fill_ssdt_generator = max98390_fill_ssdt, + .acpi_fill_ssdt = max98390_fill_ssdt, };

static void max98390_enable(struct device *dev)

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

18 May 18 May

6:44 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Correct variable name .acpi_fill_ssdt ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Mon, 18 May 2020 06:44:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

shkim (Code Review)

7:23 a.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

Hello build bot (Jenkins), Furquan Shaikh, SH Kim,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41496

to look at the new patch set (#2).

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

driver/i2c/max98390: Fix build error related to max98390 driver

Fix coreboot build error with adding this driver

BUG=b:149443429 BRANCH=None TEST=built without errors

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41496/2

shkim (Code Review)

7:24 a.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

Hello build bot (Jenkins), Furquan Shaikh, SH Kim,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41496

to look at the new patch set (#3).

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

driver/i2c/max98390: Fix build error related to max98390 driver

Fix coreboot build error with adding this driver

BUG=b:149443429 BRANCH=None TEST=built without errors

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41496/3

shkim (Code Review)

7:25 a.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

Patch Set 3:

Included one more change to fix following build error

src/drivers/i2c/max98390/max98390.c:89:20: error: initialization of 'void (*)(const struct device *)' from incompatible pointer type 'void (*)(struct device *)' [-Werror=incompatible-pointer-types] .acpi_fill_ssdt = max98390_fill_ssdt, ^~~~~~~~~~~~~~~~~~ src/drivers/i2c/max98390/max98390.c:89:20: note: (near initialization for 'max98390_ops.acpi_fill_ssdt')

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 07:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:11 p.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 17:11:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:13 p.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 18 May 2020 17:13:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 May 20 May

9:11 a.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

driver/i2c/max98390: Fix build error related to max98390 driver

Fix coreboot build error with adding this driver

BUG=b:149443429 BRANCH=None TEST=built without errors

Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Reviewed-on: https://review.coreboot.org/c/coreboot/+/41496 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/drivers/i2c/max98390/max98390.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index c8d7699..24c500b 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -15,7 +15,7 @@

#define MAX98390_DP_INT(key, val) acpi_dp_add_integer(dp, "maxim," key, (val))

-static void max98390_fill_ssdt(struct device *dev) +static void max98390_fill_ssdt(const struct device *dev) { struct drivers_i2c_max98390_config *config = dev->chip_info; const char *scope = acpi_device_scope(dev); @@ -86,7 +86,7 @@ .read_resources = noop_read_resources, .set_resources = noop_set_resources, .acpi_name = max98390_acpi_name, - .acpi_fill_ssdt_generator = max98390_fill_ssdt, + .acpi_fill_ssdt = max98390_fill_ssdt, };

static void max98390_enable(struct device *dev)

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

11 a.m.

New subject: Change in coreboot[master]: driver/i2c/max98390: Fix build error related to max98390 driver

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41496 )

Change subject: driver/i2c/max98390: Fix build error related to max98390 driver ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3678 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3677 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3676 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3675

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d76ec72ca6ae9ac54ab05f15ea92beb645acd5c Gerrit-Change-Number: 41496 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 20 May 2020 11:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1594

days inactive

1596

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
shkim (Code Review)
Tim Wawrzynczak (Code Review)