Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86474?usp=email )
(
6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/trulo/var/uldrenite: Add Fn support and clean up Kconfig order ......................................................................
mb/trulo/var/uldrenite: Add Fn support and clean up Kconfig order
Support Fn key on uldrenite emits a scancode of 94 (0x5e) and order the Kconfig.
BUG=b:394749952 TEST=fn + top row (F1~F12) keys work fine
Change-Id: I92c1bd200f1849a460943bdb96ab122d464a0f40 Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86474 Reviewed-by: John Su john_su@compal.corp-partner.google.com Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Andy Ebrahiem ahmet.ebrahiem@9elements.com Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/brya/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-)
Approvals: John Su: Looks good to me, approved Subrata Banik: Looks good to me, approved Andy Ebrahiem: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 31948fbd..2e57055 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -643,12 +643,13 @@ select BOARD_GOOGLE_BASEBOARD_TRULO select BOARD_ROMSIZE_KB_32768 select CHROMEOS_WIFI_SAR if CHROMEOS - select SOC_INTEL_TCSS_USE_PDC_PMC_USBC_MUX_CONFIGURATION + select DRIVERS_WWAN_FM350GL + select ENFORCE_MEM_CHANNEL_DISABLE select HAVE_PCIE_WWAN select HAVE_WWAN_POWER_SEQUENCE - select DRIVERS_WWAN_FM350GL + select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD select SOC_INTEL_COMMON_BLOCK_HDA_VERB - select ENFORCE_MEM_CHANNEL_DISABLE + select SOC_INTEL_TCSS_USE_PDC_PMC_USBC_MUX_CONFIGURATION
config BOARD_GOOGLE_VELL select BOARD_GOOGLE_BASEBOARD_BRYA