Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49811 )
Change subject: soc/amd/picasso/acpi: Add UID for PCI INT devices ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49811/comment/9ae97836_d36429fb PS1, Line 9: We need to have unique UIDs for each device. not sure if every device needs that, but every _HID needs either be unique or a unique _UID needs to be in the same object
File src/soc/amd/picasso/acpi/pci_int.asl:
https://review.coreboot.org/c/coreboot/+/49811/comment/dba31e52_5d3e7372 PS1, Line 103: PCI_LINK(INTA, PIRA, IORA, 1) 1-indexed or 0-indexed, that is the question ;) I'd use 0-indexed here
-
Felix Held (Code Review)