Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63109 )
Change subject: soc/mediatek: Add a configurate "USE_CBMEM_DRAM_INFO" ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63109/comment/c29734b2_4a02b6e1 PS1, Line 10: emove : this assertion
done. […]
Done
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/63109/comment/0bb2a827_942b2d34 PS2, Line 53: FILL_DRAM_INFO_FROM_BLOB
no need to mention blob? […]
Done
https://review.coreboot.org/c/coreboot/+/63109/comment/0cced35c_bb8e02e8 PS2, Line 54: fill
filling
Done
https://review.coreboot.org/c/coreboot/+/63109/comment/94ed0934_65657803 PS2, Line 56: , and the DRAM : information is passed from DRAM blob.
I think blob or not is not that important; it's more like if the mem-ref code has it or not. […]
Done
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/63109/comment/2b845177_df62c4e8 PS2, Line 138: CONFIG
!CONFIG ?
Done
-
Rex-BC Chen (Code Review)