Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/1
diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc new file mode 100644 index 0000000..267cd0d --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +MEM_TYPE = lp4x +SPD_SOURCES = +SPD_SOURCES += spd-9.hex # ID = 0(0b0000) Parts = NT6AP256T32AV-J2 +SPD_SOURCES += spd-8.hex # ID = 1(0b0001) Parts = MT53E512M32D2NP-046 WT:F diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt new file mode 100644 index 0000000..4c76adf --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +NT6AP256T32AV-J2 0 (0000) +MT53E512M32D2NP-046 WT:F 1 (0001) diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt new file mode 100644 index 0000000..9f146d4 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +NT6AP256T32AV-J2 +MT53E512M32D2NP-046 WT:F
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/8
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
Patch Set 9: Code-Review+1
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Nick Vaccaro, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#10).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:E Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/10
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:E Byte# Current New Explanation 4 0x15 0x16 This part has only 1 die. Hence, density per die is 16Gb. 6 0x90 0x04 1 die in package and 2 channels per die. 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41880 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc new file mode 100644 index 0000000..8552e95 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc @@ -0,0 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += spd-7.hex # ID = 0(0b0000) Parts = NT6AP256T32AV-J2 +SPD_SOURCES += spd-1.hex # ID = 1(0b0001) Parts = MT53E512M32D2NP-046 WT:E diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt new file mode 100644 index 0000000..3c61328 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt @@ -0,0 +1,3 @@ +DRAM Part Name ID to assign +NT6AP256T32AV-J2 0 (0000) +MT53E512M32D2NP-046 WT:E 1 (0001) diff --git a/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt new file mode 100644 index 0000000..8d043d7 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt @@ -0,0 +1,2 @@ +NT6AP256T32AV-J2 +MT53E512M32D2NP-046 WT:E
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41880 )
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
Patch Set 11:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5076 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5075 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5074 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5073
Please note: This test is under development and might not be accurate at all!