Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Aamir Bohra, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41880
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go ......................................................................
mb/google/dedede/var/waddledoo: Use auto-generated Makefile.inc using gen_part_id.go
This change adds mem_list_variant.txt that contains the list of memory parts used by waddledoo and Makefile.inc generated by gen_part_id.go using mem_list_variant.txt.
In the final change of the series, all dedede variants will be switched from using the current SPDs to new auto-generated SPDs.
Differences in auto-generated SPD from current SPD are as follows: Part: MT53E512M32D2NP-046 WT:F Byte# Current New Explanation 9 0x40 0x00 Unused by MRC. 19 0x0F 0xFF As per JEDEC spec, tckMax should be 100ns. So, value should be 0xFF as per datasheet. 123 0x00 0xE5 Fine offset for taa. Expected value is 0xE5 as per datasheet. 125 0xE1 0xE0 Fine offset for tckMin. As per datasheet tckMin is 0.468ns. So, this comes out to be 0xE0. Additionally, manufacturer name bytes are set to 0.
Part: NT6AP256T32AV-J2 Waddledoo started assigning DRAM part IDs from 1. So, this change fills in Nanya part as ID 0 (though it is currently unused).
Change-Id: I3879c4f3ad942eb349b52aad397333f576599bbd Signed-off-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/dedede/variants/waddledoo/memory/Makefile.inc A src/mainboard/google/dedede/variants/waddledoo/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/waddledoo/memory/mem_list_variant.txt 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/41880/4