Attention is currently required from: Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51385 )
Change subject: Makefile.inc: add .map target
......................................................................
Patch Set 1:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51385/comment/45d1b8d2_ab723b73
PS1, Line 780: $(objcbfs)/%.elf $(objcbfs)/%.map: $(objcbfs)/%.debug
Thanks for that explanation. I was always under the impression that it was a "group". […]
What we sometimes do to settle such cases: Add a dummy rule for the
additional file that depends on the primary output, e.g.
$(objcbfs)/%.map: $(objcbfs)/%.elf
true
or if one wants to ensure that the modification dates are in order:
$(objcbfs)/%.map: $(objcbfs)/%.elf
touch $@
Haven't tested the latter, though. One thing was tested: the recipe
mustn't be empty (cf. CB:28198).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac4797969b96bf350de20e504f5676e457bd8673
Gerrit-Change-Number: 51385
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 12 Mar 2021 15:30:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment