Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48149 )
Change subject: ec/google/chromeec/acpi: Make OperationRegion brace align ......................................................................
ec/google/chromeec/acpi: Make OperationRegion brace align
Inject TAB to make OperationRegion closing brace align with opening brace.
Change-Id: Idb9f23cf6a2c249fb1fd02f4a2ac314d4f7e180b Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48149/1
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index d12274f..ce2455f 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -82,7 +82,7 @@ Offset (0x12), BTID, 8, // Battery index that host wants to read USPP, 8, // USB Port Power -} + }
#if CONFIG(EC_GOOGLE_CHROMEEC_ACPI_MEMMAP) OperationRegion (EMEM, EmbeddedControl,
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48149 )
Change subject: ec/google/chromeec/acpi: Make OperationRegion brace align ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48149 )
Change subject: ec/google/chromeec/acpi: Make OperationRegion brace align ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48149 )
Change subject: ec/google/chromeec/acpi: Make OperationRegion brace align ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48149 )
Change subject: ec/google/chromeec/acpi: Make OperationRegion brace align ......................................................................
ec/google/chromeec/acpi: Make OperationRegion brace align
Inject TAB to make OperationRegion closing brace align with opening brace.
Change-Id: Idb9f23cf6a2c249fb1fd02f4a2ac314d4f7e180b Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48149 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index d12274f..ce2455f 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -82,7 +82,7 @@ Offset (0x12), BTID, 8, // Battery index that host wants to read USPP, 8, // USB Port Power -} + }
#if CONFIG(EC_GOOGLE_CHROMEEC_ACPI_MEMMAP) OperationRegion (EMEM, EmbeddedControl,
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Furquan Shaikh (Code Review)
-
Subrata Banik (Code Review)