Change in coreboot[master]: mb/ocp/deltalake: Update SMBIOS type 8 information

[Tim Chu (Code Review)]

Tim Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47893 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

mb/ocp/deltalake: Update SMBIOS type 8 information

Update port connector information for Delta Lake.

Tested=Execute "dmidecode -t 8" to check all the information of
SMBIOS type 8 is correct.

Signed-off-by: Tim Chu 
Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 39 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/47893/1

diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 52c55b8..3f9e1c9 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -155,6 +155,38 @@
    }
 }

+static const struct port_information SMBIOS_type8_info[] = {
+	/*
+	* Port Information fields:
+	*	Internal Reference Designator,
+	*	Internal Connector Type,
+	*	External Reference Designator,
+	*	External Connector_Type,
+	*	Port Type
+	*/
+	{
+		"JCN18 - CPU MIPI60",
+		CONN_OTHER,
+		"",
+		CONN_NONE,
+		TYPE_OTHER_PORT
+	},
+	{
+		"JCN32 - TPM_CONN",
+		CONN_OTHER,
+		"",
+		CONN_NONE,
+		TYPE_OTHER_PORT
+	},
+	{
+		"JCN7 - USB type C",
+		CONN_USB_TYPE_C,
+		"",
+		CONN_NONE,
+		TYPE_USB
+	},
+};
+
 static int create_smbios_type9(int *handle, unsigned long *current)
 {
    int index;
@@ -256,6 +288,13 @@
 {
    int len = 0;

+	// add port information
+	len += smbios_write_type8(
+		current, handle,
+		SMBIOS_type8_info,
+		ARRAY_SIZE(SMBIOS_type8_info)
+		);
+
    len += create_smbios_type9(handle, current);

return len;

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47893 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
PS1, Line 158: SMBIOS
nit: lowercase

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
PS1, Line 167: {
             : 		"JCN18 - CPU MIPI60",
             : 		CONN_OTHER,
             : 		"",
             : 		CONN_NONE,
             : 		TYPE_OTHER_PORT
             : 	},
You can remove the comment above if you write the struct initializers as follows:

{
    .internal_reference_designator = "JCN18 - CPU MIPI60",
    .internal_connector_type       = CONN_OTHER,
    .external_reference_designator = "",
    .external_connector_type       = CONN_NONE,
    .port_type                     = TYPE_OTHER_PORT,
 },

[Tim Chu (Code Review)]

Hello Philipp Deppenwiese, build bot (Jenkins), Jonathan Zhang, Ryback Hung, Christian Walter, Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47893

to look at the new patch set (#2).

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

mb/ocp/deltalake: Update SMBIOS type 8 information

Update port connector information for Delta Lake.

Tested=Execute "dmidecode -t 8" to check all the information of
SMBIOS type 8 is correct.

Signed-off-by: Tim Chu 
Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 31 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/47893/2

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47893 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
PS1, Line 158: SMBIOS
> nit: lowercase

Ack

https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... 
PS1, Line 167: {
             : 		"JCN18 - CPU MIPI60",
             : 		CONN_OTHER,
             : 		"",
             : 		CONN_NONE,
             : 		TYPE_OTHER_PORT
             : 	},
> You can remove the comment above if you write the struct initializers as follows: […]

Ack

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47893 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47893 )

Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................

mb/ocp/deltalake: Update SMBIOS type 8 information

Update port connector information for Delta Lake.

Tested=Execute "dmidecode -t 8" to check all the information of
SMBIOS type 8 is correct.

Signed-off-by: Tim Chu 
Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47893
Tested-by: build bot (Jenkins) 
Reviewed-by: Jonathan Zhang 
Reviewed-by: Angel Pons 
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 31 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Jonathan Zhang: Looks good to me, but someone else must approve

diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 96b0060..72a74da 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -180,6 +180,30 @@
    }
 }

+static const struct port_information smbios_type8_info[] = {
+	{
+		.internal_reference_designator = "JCN18 - CPU MIPI60",
+		.internal_connector_type       = CONN_OTHER,
+		.external_reference_designator = "",
+		.external_connector_type       = CONN_NONE,
+		.port_type                     = TYPE_OTHER_PORT
+	},
+	{
+		.internal_reference_designator = "JCN32 - TPM_CONN",
+		.internal_connector_type       = CONN_OTHER,
+		.external_reference_designator = "",
+		.external_connector_type       = CONN_NONE,
+		.port_type                     = TYPE_OTHER_PORT
+	},
+	{
+		.internal_reference_designator = "JCN7 - USB type C",
+		.internal_connector_type       = CONN_USB_TYPE_C,
+		.external_reference_designator = "",
+		.external_connector_type       = CONN_NONE,
+		.port_type                     = TYPE_USB
+	},
+};
+
 static int create_smbios_type9(int *handle, unsigned long *current)
 {
    int index;
@@ -281,6 +305,13 @@
 {
    int len = 0;

+	// add port information
+	len += smbios_write_type8(
+		current, handle,
+		smbios_type8_info,
+		ARRAY_SIZE(smbios_type8_info)
+		);
+
    len += create_smbios_type9(handle, current);

return len;