Attention is currently required from: Maciej Pijanowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer, Michal Zygowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake
......................................................................
Patch Set 20:
(1 comment)
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/52e52fd5_60807703
PS19, Line 543: "GPP_DSW00", "PMC_BATLOW_N",
: "GPP_DSW01", "PMC_ACPRESENT",
: "GPP_DSW02", "LAN_WAKE_N",
: "GPP_DSW03", "PMC_PWRBTN_N",
: "GPP_DSW04", "PMC_SLP_S3_N",
: "GPP_DSW05", "PMC_SLP_S4_N",
: "GPP_DSW06", "PMC_SLP_A_N",
: "GPP_DSW07", "n/a",
: "GPP_DSW08", "PMC_SUSCLK",
: "GPP_DSW09", "PMC_SLP_WLAN_N",
: "GPP_DSW10
GPD, not GPP_DSW to keep consistency with other microarchitectures
Still not consistent. Please see: https://github.com/coreboot/coreboot/blob/master/util/inteltool/gpio_names/t...
The format is GPDx not GPD_xx
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4134bd03f5544b5845cde998ee526e5ddd5b51d
Gerrit-Change-Number: 73934
Gerrit-PatchSet: 20
Gerrit-Owner: Karol Zmyslowski
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michal Zygowski
miczyg94@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Karol Zmyslowski
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michal Zygowski
miczyg94@gmail.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 08:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment