[M] Change in coreboot[main]: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization

[Johannes Hahn (Code Review)]

Attention is currently required from: Mario Scheithauer, Paul Menzel, Uwe Poeche, Werner Zeh.

Johannes Hahn has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86424?usp=email )

Change subject: src/mainboard/siemens/fa_ehl: Configure LPDDR4 initialization
......................................................................

Patch Set 6:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86424/comment/be004513_06f19092?usp... :
PS5, Line 9: KConfig
> Kconfig

Done

https://review.coreboot.org/c/coreboot/+/86424/comment/1e682d76_97763e77?usp... :
PS5, Line 10: Nanya_NT6AP512T32BV-J1I.spd.hex
> How was this created?

We received the SPD file from the vendor in exactly that format.

https://review.coreboot.org/c/coreboot/+/86424/comment/49e0de83_854922fb?usp... :
PS5, Line 12: Additional
> Additional*ly*

Done

https://review.coreboot.org/c/coreboot/+/86424/comment/aed633b6_036fd580?usp... :
PS5, Line 12: confiugration
> configuration

Done

File src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig:

https://review.coreboot.org/c/coreboot/+/86424/comment/d427f60f_3cf715cd?usp... :
PS5, Line 10: 	select USE_SIEMENS_HWILIB
> Please make this a separate commit.

Thanks for mentioning that.
How should I proceed to create a new commit?
How can I separate the change form this commit?
Without this Kconfig switch the mainboard can not be build as it still contains code from the copied platform which uses hwlib functions.

File src/mainboard/siemens/fa_ehl/variants/fa_ehl/memory.c:

https://review.coreboot.org/c/coreboot/+/86424/comment/4d3a8a81_871a96b6?usp... :
PS5, Line 4: #include <gpio.h>
> Please make this a separate commit.

Acknowledged