Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, TangYiwei, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email )
Change subject: soc/intel/xeon_sp: Add GraniteRapids initial codes
......................................................................
Patch Set 26:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81316/comment/8dac9a46_9e3308d9 :
PS26, Line 7: GraniteRapids
Granite Rapids
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/8e7024f2_7fa3f7cf :
PS26, Line 9: GraniteRapids
Granite Rapids
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/8f26e0e1_5208d636 :
PS26, Line 9: FSP2.4
FSP 2. […]
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/0e4f3b21_f4cf0582 :
PS26, Line 11: SierraForest
Sierra Forest
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/790744cd_e342eee2 :
PS26, Line 13: setups the code set
sets the code set up.
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/9e686b18_0e1dbb39 :
PS26, Line 14: SapphireRapids
Sapphire Rapids
Done
Patchset:
PS26:
Please add an entry to MAINTAINERS.
Done
File src/soc/intel/xeon_sp/chip_gen6.c:
PS26:
Please describe this file and generations in the commit message.
Done
https://review.coreboot.org/c/coreboot/+/81316/comment/cbf32787_859daa40 :
PS26, Line 80: .read_resources = iio_pci_domain_read_resources,
: .set_resources = pci_domain_set_resources,
: .scan_bus = pci_host_bridge_scan_bus,
: #if CONFIG(HAVE_ACPI_TABLES)
: .acpi_name = soc_acpi_name,
: .write_acpi_tables = northbridge_write_acpi_tables,
: .acpi_fill_ssdt = pci_domain_fill_ssdt,
Please format the = consistently. (I’d prefer just one space. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b
Gerrit-Change-Number: 81316
Gerrit-PatchSet: 26
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 28 Mar 2024 02:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment