Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Intel coreboot Reviewers, Jincheng Li, Patrick Rudolph, Shuo Liu.
Jérémy Compostella has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/86567?usp=email )
Change subject: util/cbfstool: Add missing \n in debug messages
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Could you as well mention that it replaces a hardcoded function name with `__func__` ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86567?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e2c225dc16a65470f9f94db89d8ec3711e781c8
Gerrit-Change-Number: 86567
Gerrit-PatchSet: 4
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes