Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 32:
(1 comment)
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar... File src/mainboard/google/cheza/mainboard.c:
https://review.coreboot.org/#/c/29104/24/src/mainboard/google/cheza/mainboar... PS24, Line 42: i2c_init(12, 400 * KHz, 1);
Sure!, in discussion with clock team for this comment.
According to our discussion, qup enum should be defined in clock driver and qup drivers should include clock header in order to access those enums because:
1)As clock driver is the provider and the serial engine clocks are laid out by clock HW for the consumers. It is up to the consumers to use the corresponding serial engine instances as per their requirement
2) In case of the new board as well we will not be having the qup header file in the initial phase of code so it will be problematic to generate and add support in clock code.
-
Akash Asthana (Code Review)