Attention is currently required from: Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81515?usp=email )
Change subject: cpu/x86/topology: Add node ID parser
......................................................................
Patch Set 5:
(1 comment)
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/81515/comment/d9a5737d_123ecd71 :
PS5, Line 158: package_id = apicid >> (thread_bits + core_bits);
will the package bits be obtained by get_cpu_package_bits as well?
There's no definition what package_id bits are, thus currently they are set to everything above level CORE. However there could be many other levels above CORE, so it might fill in "too" much right now.
The node_id seem to be an AMD definition for "package bits", so this is all kind of confusion, undefined naming scheme.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81515?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ed1e5923aa18ca7619b32cde491fdb4da0fa0d
Gerrit-Change-Number: 81515
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 27 Mar 2024 12:21:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment