Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 54:
(5 comments)
Patch Set 54:
(2 comments)
There are some FIXME tags. Are they solvable?
They are, I added the tags explicitly so that the issues eventually get fixed.
I'd like to get the SuperIO (a cursed piece of sillycon, rather) working at some point, even if it's just the serial port.
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@11 PS54, Line 11: There are (at least) three different mainboards:
Ack
The idea is to support the three board models. AFAIK, Christoph has DT/MT and USFF, I have SFF.
https://review.coreboot.org/#/c/21774/54//COMMIT_MSG@21 PS54, Line 21: This port has been tested with: USFF
I can test this later, but not right now.
I recall checking, DT and MT use the same mainboard. They only differ in thickness.
https://review.coreboot.org/#/c/21774/54/src/mainboard/dell/optiplex_790/Kco... File src/mainboard/dell/optiplex_790/Kconfig:
https://review.coreboot.org/#/c/21774/54/src/mainboard/dell/optiplex_790/Kco... PS54, Line 22: optiplex_790_ I'd just leave the form factor, e.g.: usff/mt
https://review.coreboot.org/#/c/21774/54/src/mainboard/dell/optiplex_790/Kco... PS54, Line 30: config DEVICETREE There should be no need to override the variant mechanism for this.
What's more, an overridetree should be used instead. But we can do that later.
https://review.coreboot.org/#/c/21774/54/src/mainboard/dell/optiplex_790/Kco... File src/mainboard/dell/optiplex_790/Kconfig.name:
https://review.coreboot.org/#/c/21774/54/src/mainboard/dell/optiplex_790/Kco... PS54, Line 3: config BOARD_DELL_OPTIPLEX_790_USFF Please add an empty line between these