Attention is currently required from: Hung-Te Lin, Xin Ji, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email )
Change subject: mb/google/corsola: Increase ANX7625 data trail time
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
Patchset:
PS3:
Thank you for the improved commit message. Some more minor comments.
Commit Message:
https://review.coreboot.org/c/coreboot/+/86101/comment/51860789_11eeb051?usp... :
PS3, Line 10: caused
is caused
https://review.coreboot.org/c/coreboot/+/86101/comment/5b93471e_3fab105f?usp... :
PS3, Line 10: shorter
too short
https://review.coreboot.org/c/coreboot/+/86101/comment/de76c916_c45bfdb4?usp... :
PS3, Line 13: enter
entering
https://review.coreboot.org/c/coreboot/+/86101/comment/d6c485a0_dadc2c1c?usp... :
PS3, Line 15:
So why is +9 correct, and not +11 or +8?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86101?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57
Gerrit-Change-Number: 86101
Gerrit-PatchSet: 3
Gerrit-Owner: Xin Ji
xji@analogix.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xin Ji
xji@analogix.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 22 Jan 2025 12:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes