Attention is currently required from: shkim, SH Kim, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57107 )
Change subject: mb/google/dedede/var/bugzzy: Configure DDI port A as MIPI DSI
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
it would be good to use an enum type for the DDI port config devicetree settings instead of magic numbers with a comment what this number does. same for some other settings in the intel soc's chip.h file that could be converted into using enum; soc/amd/picasso/chip.h should be a good reference. but that's something for another patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If308f9d69fea56176527e7b67f36b29c43adb525
Gerrit-Change-Number: 57107
Gerrit-PatchSet: 2
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 15:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment