Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57219 )
Change subject: drivers/intel/fsp/Makefile: error out when FSP files aren't specified
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57219/comment/16a061c1_480b55e0
PS5, Line 114: $(warning ADD_FSP_BINARIES isn't selected even though this SoC uses the FSP.)
: $(warning The resulting image likely won't boot successfully.)
i agree that it would be much more useful to have the warning at the end of the build. […]
You can add the warnings at the end of the build with something like this:
build_complete::
printf "Warning: ADD_FSP_BINARIES isn't selected even though this SoC requires an FSP."
printf " The resulting image likely won't boot successfully."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57219
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5f2d75d066f0b4e491e9c8420b7a0cbd4ba9e28
Gerrit-Change-Number: 57219
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Sep 2021 15:11:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment