Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Stefan Reinauer, David Hendricks, Angel Pons, Subrata Banik, ron minnich.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52735 )
Change subject: doc/relnotes/4.14: add Intel Xeon-SP support status change
......................................................................
Patch Set 2:
(3 comments)
File Documentation/releases/coreboot-4.14-relnotes.md:
https://review.coreboot.org/c/coreboot/+/52735/comment/ec78225d_a792bf41
PS2, Line 67: soc
We generally write SoC, any reason not to do this here?
https://review.coreboot.org/c/coreboot/+/52735/comment/bc4339b8_bc219af8
PS2, Line 76: https://www.intel.in/content/www/in/en/products/details/processors/xeon/scal...
nit: Does Intel have a locale neutral URL scheme so that readers end up on a server close to them and their preferred language (if available)? Couldn't find one quickly.
https://review.coreboot.org/c/coreboot/+/52735/comment/7ac6180b_6f16c2a0
PS2, Line 78: https://doc.coreboot.org/mainboard/ocp/tiogapass.html
That's an internal link, so should be possible to state as ../mainboard/ocp/tiogapass.md. Advantage: When users render their own documentation, the link still points to their own instance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52735
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e
Gerrit-Change-Number: 52735
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 07 May 2021 19:38:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment