Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon Offset Value for Drawcia ......................................................................
mb/google/dedede: Update Imon Offset Value for Drawcia
Change-Id: I3eb32218040163f0abef9b8dd4c52efb16289fe7 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/48072/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 45d0b32..65e3a9b 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -63,6 +63,7 @@ }"
register "tcc_offset" = "20" # TCC of 85C + register "ImonOffset" = "1400" # Imon Offset 1.4
device domain 0 on device pci 05.0 on # IPU - MIPI Camera
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon Offset Value for Drawcia ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48072/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48072/1//COMMIT_MSG@8 PS1, Line 8: Add TEST, BRANCH and BUG info
https://review.coreboot.org/c/coreboot/+/48072/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48072/1/src/mainboard/google/dedede... PS1, Line 66: 1400 Is there any other settings required ? What about Imon slope value ?
Maulik V Vaghela has uploaded a new patch set (#2) to the change originally created by Meera Ravindranath. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
mb/google/dedede: Update Imon slope and Offset Value for Drawcia
Updating Imon slope and offset values as per recommendation of ODM based on calibaration. Updating Imon slope to 1.0 and offset to 1.4
BUG=None BRANCH=dedede TEST=Boot dedede platform and confirm values in FSP.
Change-Id: I3eb32218040163f0abef9b8dd4c52efb16289fe7 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/48072/2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48072/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48072/1//COMMIT_MSG@8 PS1, Line 8:
Add TEST, BRANCH and BUG info
Done
https://review.coreboot.org/c/coreboot/+/48072/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48072/1/src/mainboard/google/dedede... PS1, Line 66: 1400
Is there any other settings required ? […]
Done Yes, we only need Imon slope and offset values to be programmed from coreboot. Power threshold values are bydefault set in FSP
Vinay Kumar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 2: Code-Review+1
Please note effectively only offset is changed from default 0 to 1.4, as per ODM request for Draw* boards. Slope remains the same as default 1.0.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 2: Code-Review+2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48072/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48072/2//COMMIT_MSG@13 PS2, Line 13: None update with this bug id 167294777
Hello build bot (Jenkins), Maulik V Vaghela, Sumeet R Pawnikar, Vinay Kumar, Ronak Kanabar, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48072
to look at the new patch set (#3).
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
mb/google/dedede: Update Imon slope and Offset Value for Drawcia
Updating Imon slope and offset values as per recommendation of ODM based on calibaration. Updating Imon slope to 1.0 and offset to 1.4
BUG=b:167294777 BRANCH=dedede TEST=Boot dedede platform and confirm values in FSP.
Change-Id: I3eb32218040163f0abef9b8dd4c52efb16289fe7 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/48072/3
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48072/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48072/2//COMMIT_MSG@13 PS2, Line 13: None
update with this bug id 167294777
Done
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
Patch Set 3:
Please, help us to review this CL and get it merge. Thanks.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48072 )
Change subject: mb/google/dedede: Update Imon slope and Offset Value for Drawcia ......................................................................
mb/google/dedede: Update Imon slope and Offset Value for Drawcia
Updating Imon slope and offset values as per recommendation of ODM based on calibaration. Updating Imon slope to 1.0 and offset to 1.4
BUG=b:167294777 BRANCH=dedede TEST=Boot dedede platform and confirm values in FSP.
Change-Id: I3eb32218040163f0abef9b8dd4c52efb16289fe7 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48072 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Vinay Kumar vinay.kumar@intel.com Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Vinay Kumar: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 45d0b32..dcb46cc 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -63,6 +63,8 @@ }"
register "tcc_offset" = "20" # TCC of 85C + register "ImonOffset" = "1400" # Imon Offset = 1.4 + register "ImonSlope" = "100" # Imon Slope = 1.0
device domain 0 on device pci 05.0 on # IPU - MIPI Camera
-
Maulik V Vaghela (Code Review) -
Meera Ravindranath (Code Review)
-
Patrick Georgi (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Vinay Kumar (Code Review)