[M] Change in coreboot[main]: vendorcode/amd: Hook up opensil

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Martin Roth.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email )

Change subject: vendorcode/amd: Hook up opensil
......................................................................

Patch Set 15:

(2 comments)

File src/vendorcode/amd/opensil/Kconfig:

https://review.coreboot.org/c/coreboot/+/76511/comment/045dfa9e_100f6365 :
PS14, Line 8: sil
> Nit: capitalize - openSIL

oh, missed that one

File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template:

https://review.coreboot.org/c/coreboot/+/76511/comment/59bedd7b_3d86636b :
PS14, Line 17:  # openSIL isn't compatible with coreboot's assert implementation, so use special case
             :           '-D_PORTING_H_=1',
             :           '-DSIL_DEBUG_ENABLE=##SIL_DEBUG_ENABLE##',
             :           # openSIL uses coreboot assert which uses printk which warns about unused-param
> These two comments seem to contradict each other.

not really. the first one is probably just not worded too well. see Arthur's comment from November 22 about the _PORTING_H_ thing